#124 Implemented helper to generate test state #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogyrton
changed the base branch from
master
to
117-implement-table-test-state-class
Base automatically changed from
117-implement-table-test-state-class
to
master
December 12, 2024 00:57
DenTray
reviewed
Dec 12, 2024
src/Tests/TableTestState.php
Outdated
| @@ -40,6 +46,7 @@ public function assertNotChanged(): void | |||
| public function assertChangesEqualsFixture(string $fixture, bool $exportMode = false): void | |||
| { | |||
| $changes = $this->getChanges(); | |||
| $exportMode = $this->globalExportMode || $exportMode; | |||
There was a problem hiding this comment.
the assertEqualsFixture method already checking the globalExportMode property of the class
laravel-helpers/src/Traits/FixturesTrait.php
Line 104 in c5a92fd
# Conflicts: # src/Tests/ModelTestState.php
DenTray
requested changes
Dec 23, 2024
tests/ModelTestStateTest.php
Outdated
Comment on lines
45
to
46
| $mock = $this->getMockBuilder(TestCase::class) | ||
| ->disableOriginalConstructor() |
There was a problem hiding this comment.
Suggested change
| $mock = $this->getMockBuilder(TestCase::class) | |
| ->disableOriginalConstructor() | |
| $mock = $this | |
| ->getMockBuilder(TestCase::class) | |
| ->disableOriginalConstructor() |
tests/ModelTestStateTest.php
Outdated
|
|
||
| $reflection = new ReflectionClass($mock); | ||
|
|
||
| $this->assertFalse($reflection->getProperty('globalExportMode')->getValue($mock)); |
There was a problem hiding this comment.
no reasons to check the initial value of the test case class
tests/ModelTestStateTest.php
Outdated
Comment on lines
53
to
54
| $setGlobalExportMode = $reflection->getMethod('setGlobalExportMode'); | ||
| $setGlobalExportMode->invoke($mock); |
There was a problem hiding this comment.
Suggested change
| $setGlobalExportMode = $reflection->getMethod('setGlobalExportMode'); | |
| $setGlobalExportMode->invoke($mock); | |
| $reflection->getMethod('setGlobalExportMode')->invoke($mock); |
tests/ModelTestStateTest.php
Outdated
| $prepareModelTestState = $reflection->getMethod('prepareModelTestState'); | ||
| $prepareModelTestState->invoke($mock, TestModel::class); | ||
|
|
||
| $this->assertTrue($reflection->getProperty('globalExportMode')->getValue($mock)); |
There was a problem hiding this comment.
what this test case testing? you need to test that the global export mode property of created test state has the same value as in the TestCase class
DenTray
requested changes
Dec 26, 2024
tests/ModelTestStateTest.php
Outdated
| $datasetMock = collect($this->getJsonFixture('initialization/dataset.json')); | ||
| $this->mockGettingDataset($datasetMock); | ||
|
|
||
| $mock = $this |
There was a problem hiding this comment.
Suggested change
| $mock = $this | |
| $testCaseMock = $this |
tests/ModelTestStateTest.php
Outdated
| ->disableOriginalConstructor() | ||
| ->getMockForAbstractClass(); | ||
|
|
||
| $reflection = new ReflectionClass($mock); |
There was a problem hiding this comment.
Suggested change
| $reflection = new ReflectionClass($mock); | |
| $testCase = new ReflectionClass($mock); |
tests/TableTestStateTest.php
Outdated
Comment on lines
34
to
43
| $mock = $this | ||
| ->getMockBuilder(TestCase::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMockForAbstractClass(); | ||
|
|
||
| $reflection = new ReflectionClass($mock); | ||
|
|
||
| $reflection->getMethod('setGlobalExportMode')->invoke($mock); | ||
|
|
||
| $prepareTableTestState = $reflection->getMethod('prepareTableTestState')->invoke($mock, 'test_models'); |
There was a problem hiding this comment.
let's move it to the separate method which will return reflection of the TestCase class with enabled global export mode
DenTray
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch was created from this