Merge pull request #18 from RonasIT/dpankraov/order-by-related-fix

Fixed bug with scopeOrderByRelated method in Laravel 8
RonasIT · Mar 19, 2022 · bef4c90 · bef4c90
2 parents ecbfdc3 + 0144126
commit bef4c90
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Traits/ModelTrait.php b/src/Traits/ModelTrait.php
@@ -78,12 +78,12 @@ public function scopeAddFieldsToSelect($query, array $fields = [])
      * @param $query
      * @param $relations
      * @param string $desc
-     * @param string $asField
+     * @param string|null $asField
      * @param string $manyToManyStrategy
      *
-     * @return QueryBuilder
+     * @return mixed $query
      */
-    public function scopeOrderByRelated(QueryBuilder $query, string $relations, string $desc = 'DESC', ?string $asField = null, string $manyToManyStrategy = 'max'): QueryBuilder
+    public function scopeOrderByRelated($query, $relations, string $desc = 'DESC', ?string $asField = null, string $manyToManyStrategy = 'max')
     {
         if (version_compare(app()::VERSION, '5.5') <= 0) {
             return $query->legacyOrderByRelated($relations, $desc);