Apply suggestions from code review

RonasIT · Dec 12, 2024 · 14b5bad · 14b5bad
1 parent e3fb6d3
commit 14b5bad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/tests/ValidatorTest.php b/tests/ValidatorTest.php
@@ -81,10 +81,11 @@ public function testListExistsIfDuplicateValues()
     {
         $this->mockListExists([1, 2, 3]);
 
-        $validator = Validator::make(
-            ['ids' => [1, 2, 3, 3]],
-            ['ids' => 'list_exists:clients,user_id'],
-        );
+        $validator = Validator::make([
+            'ids' => [1, 2, 3, 3],
+        ] [
+            'ids' => 'list_exists:clients,user_id',
+        ]);
 
         $this->assertTrue($validator->passes());
     }

diff --git a/tests/support/Traits/SqlMockTrait.php b/tests/support/Traits/SqlMockTrait.php
@@ -436,12 +436,10 @@ protected function mockListExists(
         string $table = 'clients',
         string $keyField = 'user_id',
     ): void {
-        $countResult = [[ 'aggregate' => count($result) ]];
-
         $this->mockSelect(
             query: "select count(distinct \"{$keyField}\") as aggregate from \"{$table}\" where \"{$keyField}\" in (?, ?, ?)",
-            result: $countResult,
-            bindings: [1, 2, 3],
+            result: [[ 'aggregate' => count($result) ]],
+            bindings: $result,
         );
     }