Change the table initialization ordering so index creation doesn't fail #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of stuff has been deprecated or made stricter with return type annotations. Also, the SimplePie ad-hoc autoloader stopped working, so I switched it to use [Composer](https://getcomposer.org/) to manage the external dependencies. I have verified that this still works with PHP 8.1, although I cannot guarantee it on older versions.
A lot of stuff has been deprecated or made stricter with return type annotations. Also, the SimplePie ad-hoc autoloader stopped working, so I switched it to use [Composer](https://getcomposer.org/) to manage the external dependencies. I have verified that this still works with PHP 8.1, although I cannot guarantee it on older versions.
mysql really needs the tables to be defined in the correct order. In the future we should change the install process to put all the indexes/constraints after the table creation, which would probably be a cleaner fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #58 on a clean install on mysql 15.