Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achtung! Cthulhu CoC7 - Release v1.03 #13673

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zedafty
Copy link
Contributor

@zedafty zedafty commented Jan 11, 2025

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

  • Fix extreme damage formula (maximum weapon damage + maximum damage bonus + impalement)
  • Fix chatlog action button call based upon character name instead of character id
  • Fix occupation and interest skill points totals update on skill points reset
  • Fix monster attacks extreme damages and damage bonus
  • Fix Show Scores parameter not checked by default
  • Replace attribute "imp" by "dmg-max"
  • Add Call of Cthulhu dark visual theme
  • Add printable sheet option with print friendly styles
  • Add persistant insanity cap number bubble box and recalc button
  • Add major wound cap number bubble box
  • Add description roll template (for out of sheet macros)
  • Add empty rows sheet option for repeating sections on sheet creation
  • Add no damage chatlog text (instead of nothing displayed)
  • Add limits to minimal and maximal Credit Rating
  • Merge Investigator and Achtung! PC sheet types into PC sheet type
  • Remove advancement checkbox for Credit Rating and Cthulhu Mythos
  • Reset inline rolls default styles (e.g. use roll result in roll name)
  • Show fighting skill score next to weapon name
  • Show options blocks expanded by default
  • Make Cash field editable in view mode and auto-computed (i.e. calculate sums like 1+2+3 up to four operands)
  • Set maximum characteristic score for players to 99 (including Luck, saving Size [200 max] and Power [150 max])
  • Set maximum skill score for players to 109 (99 + 1D10 due to advancement ; except for Credit Rating and Cthulhu Mythos)

- Fix extreme damage formula (maximum weapon damage + maximum damage bonus + impalement)
- Fix chatlog action button call based upon character name instead of character id
- Fix occupation and interest skill points totals update on skill points reset
- Fix monster attacks extreme damages and damage bonus
- Fix Show Scores parameter not checked by default
- Replace attribute "imp" by "dmg-max"
- Add Call of Cthulhu dark visual theme
- Add printable sheet option with print friendly styles
- Add persistant insanity cap number bubble box and recalc button
- Add major wound cap number bubble box
- Add description roll template (for out of sheet macros)
- Add empty rows sheet option for repeating sections on sheet creation
- Add no damage chatlog text (instead of nothing displayed)
- Add limits to minimal and maximal Credit Rating
- Merge Investigator and Achtung! PC sheet types into PC sheet type
- Remove advancement checkbox for Credit Rating and Cthulhu Mythos
- Reset inline rolls default styles (e.g. use roll result in roll name)
- Show fighting skill score next to weapon name
- Show options blocks expanded by default
- Make Cash field editable in view mode and auto-computed (i.e. calculate sums like 1+2+3 up to four operands)
- Set maximum characteristic score for players to 99 (including Luck, saving Size [200 max] and Power [150 max])
- Set maximum skill score for players to 109 (99 + 1D10 due to advancement ; except for Credit Rating and Cthulhu Mythos)
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@nmbradley
Copy link
Collaborator

Hi @zedafty

Thanks for the pull request. The updated sheet looks incredible.

We have to clear the usage of logos and so forth with our publishing partners and we've submitted some requests via our Partner Relationships team to ensure that they are comfortable with their logos being used in this way.

We should expect a response in a few days, and we'll let you know if any further steps are required.

@nmbradley nmbradley added blocked Awaiting Verification We're currently verifying that this sheet has official authorization from the publisher. labels Jan 14, 2025
@kfroll20
Copy link
Contributor

Hello @zedafty!

We heard back from our Partner Relations team and unfortunately we cannot merge this PR until the logos are removed since this sheet is not official. Once those logos are removed, we can go forward with getting this merged. Thank you for your understanding.

@zedafty
Copy link
Contributor Author

zedafty commented Jan 17, 2025

Thank you for the feedback and explanations @nmbradley and @kfroll20 !

I understand the matter. Does a custom logo, not using the Chaosium logo font, would be ok for the character sheet ?

@kfroll20
Copy link
Contributor

Thank you for the feedback and explanations @nmbradley and @kfroll20 !

I understand the matter. Does a custom logo, not using the Chaosium logo font, would be ok for the character sheet ?

As long as you're not using the logo, font, or either that are indistinguishable from the official one, you should be good to go. We appreciate your understanding :)

– Remove official Call of Cthulhu logos
– Add unofficial Call of Cthulhu logos
@zedafty
Copy link
Contributor Author

zedafty commented Jan 25, 2025

Thank you for response @kfroll20 !

I removed the official logos for Call of Cthulhu theme and replaced them with unofficial ones using a typewriter font that I hope should be different enough to prevent any licenses issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Verification We're currently verifying that this sheet has official authorization from the publisher. blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants