Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF1 Community #13669

Merged
merged 1 commit into from
Jan 14, 2025
Merged

PF1 Community #13669

merged 1 commit into from
Jan 14, 2025

Conversation

vince-roll20
Copy link
Contributor

@vince-roll20 vince-roll20 commented Jan 10, 2025

  • monster statblock parse button fixed.
  • small css culling and combining
  • linter formatting adjustments to js modules

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

- monster statblock parse button fixed.
- small css culling and combining
- linter formatting adjustments to js modules
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@NorWhal
Copy link
Contributor

NorWhal commented Jan 14, 2025

Hi @vince-roll20, everything looks good here but I did have one request for the future:

We totally understand the value behind minifying the javascript to bring down page load times, but could you include the source code in future PRs so we have an easier time with our moderation processes? As it stands, we need to unminify and check the diff of the files manually.

Thanks in advance,
Nora

@NorWhal NorWhal merged commit 1ba142e into Roll20:master Jan 14, 2025
1 check passed
@vince-roll20
Copy link
Contributor Author

vince-roll20 commented Jan 14, 2025

Hi @vince-roll20, everything looks good here but I did have one request for the future:

We totally understand the value behind minifying the javascript to bring down page load times, but could you include the source code in future PRs so we have an easier time with our moderation processes? As it stands, we need to unminify and check the diff of the files manually.

Thanks in advance, Nora

Roger that.

I believe the PF sheet was one of the first sheets developed with es modules and webpack to bundle... Much more common these days. The source files have resided at: https://github.com/Roll20-Pathfinder-Character-Sheet/Roll20-Pathfinder-Character-Sheet for 7+ years. ;-)

I'll work up a pull to include the source files.
Thanks

vince-roll20 added a commit to vince-roll20/roll20-character-sheets that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants