Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Delta Green by ArcDream #13667

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Bugfix] Delta Green by ArcDream #13667

wants to merge 2 commits into from

Conversation

uriele
Copy link
Contributor

@uriele uriele commented Jan 10, 2025

feat: repeating sections updated when leveling up

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

  • Fix the default size of the logo, so if the image server stops working, it does not mess up the sheet (currently, the svg image was not loading correctly)
  • Change the link to the logo from my repository to the roll20 one (I forgot to update it when I switched from jpg to svg file)
  • Leveling up failed skills automatically updated the repeating sections depending on it (I changed silent from true to false in the leveling up script and checked that it does not interfere with anything else in the sheet)

feat: repeating sections updated when leveling up
@uriele uriele requested a review from a team as a code owner January 10, 2025 15:45
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants