Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daggerheart v1.5 character sheet #13625

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Hotbloodhypno
Copy link

@Hotbloodhypno Hotbloodhypno commented Dec 20, 2024

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < DAGGERHEART > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < Darrinton Press > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < Daggerheart 2D12 > (i.e. Dungeons & Dragons, FATE)

  • [ x] I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • [ x ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < www.darringtonpress.com >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Beta game from Darringtom Press
All new sheet.. (hopefully bugs and spelling mistakes are removed)

@kfroll20
Copy link
Contributor

kfroll20 commented Jan 2, 2025

Hello @Hotbloodhypno!

Thank you for creating and submitting the Daggerheart v1.5 sheet! Just a few things before we get this merged:

  • the sheet.json is invalid (looks like it's just missing a colon and opening double quotes for the value on the last line)
  • we do not allow table elements to be used in new sheets (you can reference the community wiki page for guidance on submitting new sheets)
  • There are two sheets included in this PR and we only allow changes for one sheet per PR (I assume Scion wasn't meant to be included in here). Please remove the changes for Scion in this PR

Once these are addressed, I can take a final look and get this merged.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants