Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correct math on Mythic D6 Success Rolls #13621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-1789
Copy link
Contributor

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Per discussion at https://app.roll20.net/forum/post/12154470/mythic-d6-success-threshold/?pageforid=12154577#post-12154577, the current math for Mythic D6 Successes treats any roll of 3, 4, 5, or 6 as a success. Per the rules this is not the intent, as success should occur on rolls of 4, 5, or 6.

This seems to be happening as the dice math in the current html code states >3 which seems like it should work, but per discussions above, this is actually treated as Greater Than or Equal to Three.

To test this I made a custom sheet in my personal roll20 account with this math. As it lacks many of the files found in the official Mythic D6 Sheet there's no pretty formatting, but since this is a calculation-only change, this was adequate for my purposes. I verified these changes worked for both wild and standard dice.

mythic-d6-test-01 mythic-d6-test-02

As this is a company sheet I imagine you'll want to get approval from them as well - not sure what your policy for that is - or feel free to get me in touch with them (I don't have a contact with them).

@daniel-1789 daniel-1789 requested a review from a team as a code owner December 18, 2024 23:23
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@NorWhal
Copy link
Contributor

NorWhal commented Dec 19, 2024

Thank you, @daniel-1789!

@Anduh, you are the code owner here. From the forum discussion, this looks like a very straightforward and necessary fix but policy is to notify you and give you final say in case you have a version of this sheet off the repo that needs updating.

@Anduh
Copy link
Contributor

Anduh commented Dec 20, 2024

I'll try to find the time over the weekend to look this over, and reach out to the publisher on this correction.

Someone might have mentioning this math issue to me before, so this is probably correct, and have the rulebook somewhere so can check this.

@nmbradley
Copy link
Collaborator

@Anduh Just a quick nudge on this, and to let both you and @daniel-1789 know that we've reached out to the publisher for authorization in absence of a response here.

@Anduh
Copy link
Contributor

Anduh commented Jan 24, 2025

Hi, I asked about this from the publisher and the reply was:

"Yes, it should be 4, 5, and 6 for a success."

So the fix is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants