-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use @rocket.chat/message-parser instead of Commonmark #6080
base: develop
Are you sure you want to change the base?
Conversation
app/containers/Avatar/Avatar.tsx
Outdated
image = ( | ||
<MarkdownContext.Provider | ||
value={{ | ||
getCustomEmoji: process.env.USE_STORYBOOK ? getStorybookCustomEmoji : getCustomEmoji |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't inject Storybook inside production code like this.
getCustomEmoji
is already a prop, so can't we just send getStorybookCustomEmoji
as prop to Avatar?
BTW I think we should do this change in a separate PR.
This one is big already and the storybook changes should be done separately, because it's an important change and it gets proper visibility.
Proposed changes
Remove the deprecated markdown and sets our messageParser and the new markdown as the default.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-103
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments