Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use @rocket.chat/message-parser instead of Commonmark #6080

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Dec 30, 2024

Proposed changes

Remove the deprecated markdown and sets our messageParser and the new markdown as the default.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-103

How to test or reproduce

  • Open the app;
  • Go to room;
  • Send a message;

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title chore: started parser changes chore: Use @rocket.chat/message-parser instead of Commonmark Jan 3, 2025
@diegolmello diegolmello marked this pull request as ready for review January 7, 2025 19:09
image = (
<MarkdownContext.Provider
value={{
getCustomEmoji: process.env.USE_STORYBOOK ? getStorybookCustomEmoji : getCustomEmoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't inject Storybook inside production code like this.
getCustomEmoji is already a prop, so can't we just send getStorybookCustomEmoji as prop to Avatar?

BTW I think we should do this change in a separate PR.
This one is big already and the storybook changes should be done separately, because it's an important change and it gets proper visibility.

app/containers/Avatar/Avatar.tsx Outdated Show resolved Hide resolved
app/containers/CollapsibleText/index.tsx Outdated Show resolved Hide resolved
app/containers/markdown/components/Strike.tsx Outdated Show resolved Hide resolved
app/containers/markdown/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants