Make testable #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was POST https://rocketchat.server/api/v1/login HTTP/1.1 1 1 map[Content-Type:[application/json]] {password=PASSWORD&user=USER} Now POST https://rocketchat.server/api/v1/login HTTP/1.1 1 1 map[Content-Type:[application/json]] {{"username":"USER","password":"PASSWORD"}}
Using multi pagkages makes forked development very hard, moved things round to have all in single pagkage * Added Doer - can pass this in * REST channels has good coverage * REST information has good coverage
Added missing tests for REST Included error tests
Added missing tests for REST Included error tests
Renamed channels tests
Extended the example to include a PostMessage
Most client methods are used by other func during tests Very simple tests only
Login and Logout
I have left some dead/unsed code that needs cleanup
Closed
|
First off thanks for your contribution!
Strongly disagree with this. By putting in a subpackage you are allowing that one package to be included where you may not want to include the entire sdk here. Its fundamental to go. Going to take a look at the rest of the code changes. Thanks again for contributing |
|
I have created another pull request that contains the change to make testing easer. (#13) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done a large refactor to make development and testing easier.
Why have I made changes ?
sub-packages make it hard ! Having models in a sub-package makes it hard under the golang dependancy management to fork and work on changes, moving all in a single package solves this.
make testing easy I have added a http doer to the client , this allows for testing to include the response that you want to test with.
its a work in progress I have done a lot of changes, and some are still a bit messy. More work is needed
started to lint I find lint'ing of code very helpful
make linttest coverage Have also added a compact way to look at test coverage
make testKeen for your feedback,
Chris