Channels.archive #12
Channels.archive #12
Conversation
Was POST https://rocketchat.server/api/v1/login HTTP/1.1 1 1 map[Content-Type:[application/json]] {password=PASSWORD&user=USER} Now POST https://rocketchat.server/api/v1/login HTTP/1.1 1 1 map[Content-Type:[application/json]] {{"username":"USER","password":"PASSWORD"}}
Using multi pagkages makes forked development very hard, moved things round to have all in single pagkage * Added Doer - can pass this in * REST channels has good coverage * REST information has good coverage
Added missing tests for REST Included error tests
Added missing tests for REST Included error tests
Renamed channels tests
Extended the example to include a PostMessage
Most client methods are used by other func during tests Very simple tests only
Login and Logout
I have left some dead/unsed code that needs cleanup
Make testable
All tests are passing :-)
…SDK into subpackage
Included testing
NOt fully happy with it but its a start
Missed this :-)
Creates a new public channel Including simple test
Removes the channel from the user’s list of channels. Included simple test
Archives a channel.
Unarchives a channel.
|
All these PR's are based on your previous PR's. Makes this extremely hard to review. Ideally when doing this sort of thing you keep your master branch completely the same as our master branch. Then you checkout from master and do a feature and open a PR. Then if doing another feature you switch to master, and checkout again from master. This way when you open the PR your PR contains isolated changes. This makes it much easier to review. We could also merge the easy ones like this one and your other two channel based ones quickly instead of having to try to figure out which one to review first. :) |
|
Agreed with @geekgonecrazy, I honestly am having trouble understanding everything that has happened |
|
I have created another pull request that contains a change. (#13) I don't have time at the moment to roll my master branch back but will to make it easer for reviews. |
Included testing
NOt fully happy with it but its a start
…SDK into channels.kick
…Go.SDK into channels.kick
Channels.kick
Creates a new public channel Including simple test
Removes the channel from the user’s list of channels. Included simple test
…SDK into channels.create
…t.Go.SDK into channels.create
Channels.create
Archives a channel.
Unarchives a channel.
…SDK into channels.archive
…at.Go.SDK into channels.archive
Archives a channel.
Unarchives a channel.
Archives a channel.
…at.Go.SDK into channels.archive
|
Are you able to resolve the conflicts here? Would be good to review and get this added. Others might find this useful |
|
Chris Joyce seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Archiving and UnArchiving