fix: adjust index import from apps compiling #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-lehnen-rc
approved these changes
Mar 7, 2024
d-gubert
approved these changes
Mar 7, 2024
d-gubert
deleted the
fix/SUP-160/fixing-apps-compiler-index-file-interpreting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the resolvePath method within the TypescriptCompiler class. The method resolvePath is responsible for resolving file paths based on the containing file and module name. The improvement ensures that when a file is successfully resolved, it is directly pushed into the resolvedModules array with the appropriate structure.
Previously, the method only checked if the resolved path exists in the
result.filesobject. With this enhancement, if the resolved path exists, the corresponding object with the resolved filename is directly added to the resolvedModules array, simplifying the logic and improving readability.