Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added avatar in thread message #921

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 17, 2025

Brief Title

Format the thread message header and add avatar of the thread-creating user.

Acceptance Criteria fulfillment

  • Add avatar.
  • format text.
  • improve time format.
  • add tooltip

Fixes #920

Video/Screenshots

Before:
Screencast from 2025-01-18 02-10-28.webm
After:
Screencast from 2025-01-18 02-06-58.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-921 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010
Copy link
Contributor

Hey @thepiyush-303 , please update your PR description by adding a video , also could you please show me how it behaves if more than 2 users are involved in a thread ?

@thepiyush-303
Copy link
Contributor Author

I will add 'video' once i have commit some more changes, if you want to see the changes then look into the issue I have attached screenshot their.

@abirc8010
Copy link
Contributor

I will add 'video' once i have commit some more changes

To avoid any confusion, could you please convert your PR into a draft if it's not yet ready for review?

if you want to see the changes then look into the issue I have attached screenshot their.

Yes but that is for one user but what happens when there are more than two users? It might be better not to display all the avatars. For instance, in Rocket.Chat, if four users are involved in a thread, it displays the avatars of two users followed by "+2"

@thepiyush-303
Copy link
Contributor Author

Now it is complete,

in Rocket.Chat, if four users are involved in a thread, it displays the avatars of two users followed by "+2"

yes, I have made changes as to show only one userAvatar who creates thread message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Add avatar in thread messages, and format thread title
2 participants