Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced options to LN payout form #326

Merged
merged 6 commits into from
Nov 24, 2022

Conversation

Reckless-Satoshi
Copy link
Collaborator

@Reckless-Satoshi Reckless-Satoshi commented Nov 21, 2022

What does this PR do?

Adds 2 new options to the Lightning Payout form:

  1. Adds UI for fully integrated use of Lnproxy (https://github.com/lnproxy/lnproxy ). Currently only one lnproxy service provider. The form has dropdown to select the lnproxy server (though there is only one). Does not work on testnet or clearnet!

  2. Adds Custom routing budget option. This is a long overdue option. With this inclusion, the buyer covers the routing fees. That means, wallets behind expensive private channels can now be used with RoboSats (yet the user must enable "Custom Routing Budget" and enter a sufficient amount manually.

Checklist before merging

  • Make sure you have installed and initialized pre-commit. pip install pre-commit and pre-commit install

@Reckless-Satoshi
Copy link
Collaborator Author

Lnproxy feature almost ready, having issues with Cross-site origins, related issue https://github.com/lnproxy/lnproxy/issues/12

Custom routing budget frontend feature ready. Still needs the backend work and rework on some models and logics: it might render current frontend v0.3.0 incompatible again 😄

@Reckless-Satoshi Reckless-Satoshi force-pushed the add-routing-budget-and-lnproxy branch from d002098 to 84320d5 Compare November 24, 2022 08:35
@Reckless-Satoshi
Copy link
Collaborator Author

Ready to merge.

Use Lnproxy feature is disabled in Android Native app temporarily. Enabling it would require to re-work the apiClient service (it can only handles json responses at the moment). Given that json responses might soon be available from lnproxy coordinators, it is best to wait. Let us know @lnproxy :D

@Reckless-Satoshi Reckless-Satoshi marked this pull request as ready for review November 24, 2022 17:40
@Reckless-Satoshi Reckless-Satoshi merged commit 86e6bed into main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant