Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging refactor #14

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Logging refactor #14

merged 3 commits into from
Dec 26, 2023

Conversation

babysnakes
Copy link
Contributor

@babysnakes babysnakes commented Dec 26, 2023 •
edited
Loading

  • Added logger names to all logs
  • Cleaned up the properties passed to the logs
  • Configured logging for development/production

Some features (like the logs during cleanup which lack custom resource property) wll gain them during reconcile loop workflow refactor.

@babysnakes babysnakes requested a review from a team as a code owner December 26, 2023 07:48
@babysnakes babysnakes changed the title Logging refactor DEV-71159 Logging refactor Dec 26, 2023
@babysnakes babysnakes changed the title DEV-71159 Logging refactor Logging refactor Dec 26, 2023
@babysnakes
Change the logging in production
3abc368 
  also update development invocation accordingly.
@nissanitz nissanitz merged commit 5074eaf into Riskified:main Dec 26, 2023
5 of 6 checks passed
bnayah pushed a commit that referenced this pull request Dec 28, 2023
Merge pull request #14 from babysnakes/logging-refactor
df63895 
Logging refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nissanitz nissanitz nissanitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babysnakes @nissanitz