Change the logging in production

  also update development invocation accordingly.

.run/Build & Run.run.xml

@@ -2,6 +2,7 @@
   <configuration default="false" name="Build &amp; Run" type="GoApplicationRunConfiguration" factoryName="Go Application">
     <module name="dynamic-environment" />
     <working_directory value="$PROJECT_DIR$" />
+    <parameters value="-zap-devel" />
     <envs>
       <env name="ENABLE_WEBHOOKS" value="false" />
     </envs>

Makefile

@@ -121,7 +121,7 @@ build: manifests generate fmt vet ## Build manager binary.
 
 .PHONY: run
 run: manifests generate fmt vet ## Run a controller from your host.
-	ENABLE_WEBHOOKS=false go run ./main.go
+	ENABLE_WEBHOOKS=false go run ./main.go -zap-devel
 
 .PHONY: docker-build
 docker-build: ## Build docker image with the manager.

README.md

@@ -1,8 +1,7 @@
 # Dynamic Environment Controller <img src="https://riskified.github.io/dynamic-environment-docs/img/de-logo.svg" alt="Dynamic Environment Logo" width="20">
 
-
 A k8s operator which supports testing on a multi-test workflows environment in a
-transparent way. This operator will listen to DynamicEnv, a new Riskified custom resource. 
+transparent way. This operator will listen to DynamicEnv, a new Riskified custom resource.
 In this resource we will configure the services from which we want to create a subset with new version of our app 
 and apply all the requirements for routing the requests to the matching subsets.
 Ready to get started? Check out the [docs](https://riskified.github.io/dynamic-environment-docs/).
@@ -161,6 +160,9 @@ To run our development operator:
 make install run
 ```
 
+> Note: if you run in development mode not using the `Makefile` add `-zap-devel` to your parameters
+> for better development logging.
+
 On another shell session you can deploy a sample _dynamic-environment_ resource to see the effect:
 
 ```shell

config/manager/manager.yaml

@@ -35,6 +35,9 @@ spec:
         - version
         - --default-version
         - shared
+        # uncomment the next two lines to set log level to debug (also error is valid value, default is info)
+        # - --zap-log-level
+        # - debug
         # uncomment below (and edit to your liking) to specify labels to be removed (comma separated list)
         #- --remove-labels
         #- argocd.argoproj.io/instance

helm/dynamic-environment/templates/deployment.yaml

@@ -60,6 +60,10 @@ spec:
         - --remove-labels
         - {{ $removeLabels }}
         {{- end }}
+        {{- if .Values.command.debugLogger }}
+        - --zap-log-level
+        - debug
+        {{- end }}
         command:
         - /manager
         image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"

helm/dynamic-environment/values.yaml

@@ -34,6 +34,8 @@ command:
   # Specify a default version other than the default 'shared'. This version will be used when searching default
   # DestinationRule. Could be specified per subset in the CR.
   defaultVersion: "shared"
+  # Set log level to debug
+  debugLogger: false
 
 # Labels to be deleted form deployments when duplicating (e.g. labels that connect deployment to argocd app):
 labelsToRemove: []

main.go

@@ -98,9 +98,7 @@ func main() {
 	flag.StringVar(&defaultVersion, "default-version", names.DefaultVersion,
 		"The global default version - this version is the one that gets the default route. Could be overridden per subset.")
 	flag.Var(&labelsToRemove, "remove-labels", "A comma separated list of labels to remove when duplicating deployment.")
-	opts := zap.Options{
-		Development: true,
-	}
+	opts := zap.Options{}
 	opts.BindFlags(flag.CommandLine)
 	flag.Parse()