Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS support #471

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add visionOS support #471

merged 3 commits into from
Oct 2, 2024

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Jun 28, 2024

Adding visionOS support

@aboedo aboedo self-assigned this Jun 28, 2024
@aboedo aboedo added the pr:feat A new feature label Jun 28, 2024
#elif UNITY_IPHONE && !UNITY_EDITOR
#elif (UNITY_IOS || UNITY_VISIONOS) && !UNITY_EDITOR
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be the reason why before this PR, it would still compile, but no-op

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment but LGTM!

@@ -1,5 +1,5 @@

#if UNITY_EDITOR && UNITY_IOS
#if UNITY_EDITOR && (UNITY_IOS || UNITY_VISIONOS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to test this, but do we need to also check for vision os in line 16 below? https://docs.unity3d.com/ScriptReference/BuildTarget.VisionOS.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump to this @aboedo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it support Unity-VisionOS now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing with the new BuildTarget.VisionOS, this actually brakes with the current unity version we are using and it would be considered a breaking change. In any case, this script shouldn't really be needed in modern unity versions so we can merge without it.

@tonidero tonidero marked this pull request as ready for review October 2, 2024 15:44
@tonidero tonidero merged commit ee4288d into main Oct 2, 2024
7 checks passed
@tonidero tonidero deleted the vision-os-support branch October 2, 2024 15:46
tonidero pushed a commit that referenced this pull request Oct 2, 2024
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Add visionOS support (#471) via Andy Boedo (@aboedo)
### 📦 Dependency Updates
* Bump fastlane from 2.222.0 to 2.223.1 (#509) via dependabot[bot]
(@dependabot[bot])
@AstoraGray
Copy link

Hello, our team encountered the following error while packaging RevenueCat for Unity version 7.2.0 to Vision Pro using Xcode. The error did not occur when rolling back to version 7.1.2, and the packaging was successful, so there should still be some issues with version 7.2.0's support for Vision Pro.
image

@aboedo
Copy link
Member Author

aboedo commented Oct 8, 2024

@AstoraGray thanks for letting us know! We'll take care of it

@aboedo
Copy link
Member Author

aboedo commented Oct 8, 2024

Update: turns out this is a bit trickier than expected since EDM4U, which we use to manage iOS dependencies in Unity, doesn't support VisionOS yet.

We're studying alternatives

kaushikpaperboat added a commit to Kiddopia/purchases-unity that referenced this pull request Oct 30, 2024
* commit '58990de155c37f42d662c33f2eff9b3d7984b3c6': (26 commits)
  Update VERSIONS.md
  Version bump for 7.3.0
  Adds docs to `StoreProduct` (RevenueCat#521)
  Fix metadata values types (RevenueCat#523)
  [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.7.0 (RevenueCat#524)
  support displaying deferred win-back StoreKit messages
  Bump rexml from 3.3.8 to 3.3.9 (RevenueCat#520)
  Bump danger from 9.5.0 to 9.5.1 (RevenueCat#518)
  Bump fastlane from 2.224.0 to 2.225.0 (RevenueCat#517)
  [AUTOMATIC] Release/7.2.1 (RevenueCat#514)
  [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.5.0 (RevenueCat#513)
  Bump fastlane from 2.223.1 to 2.224.0 (RevenueCat#512)
  [AUTOMATIC] Release/7.2.0 (RevenueCat#511)
  Add visionOS support (RevenueCat#471)
  Bump fastlane from 2.222.0 to 2.223.1 (RevenueCat#509)
  [AUTOMATIC] Release/7.1.2 (RevenueCat#508)
  [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.3.0 (RevenueCat#507)
  [AUTOMATIC] Release/7.1.1 (RevenueCat#506)
  Bump fastlane-plugin-revenuecat_internal from 5140dbc to 55a0455 (RevenueCat#505)
  update allowSharingAppStoreAccount deprecation message
  ...

# Conflicts:
#	.version
#	CHANGELOG.latest.md
#	CHANGELOG.md
#	RevenueCat/Plugins/Android/PurchasesWrapper.java
#	RevenueCat/Plugins/iOS/PurchasesUnityHelper.m
#	RevenueCat/package.json
#	VERSIONS.md
@AstoraGray
Copy link

Update: turns out this is a bit trickier than expected since EDM4U, which we use to manage iOS dependencies in Unity, doesn't support VisionOS yet.

We're studying alternatives

I wanted to discuss the recent updates regarding the visionOS support that was merged into the main branch recently. As our project team continues to navigate the integration of this feature, I wanted to kindly inquire if it would be feasible to complete the development by the end of this year.

This functionality is crucial for our project, and having it finalized by then would greatly assist us in meeting our upcoming deadlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants