Pre-emptively fetch answer reaction state

[raccube]

No description provided.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4314010) 95.41% compared to head (8facb44) 95.47%.
Report is 50 commits behind head on main.

Files	Patch %	Lines
app/controllers/discover_controller.rb	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1459      +/-   ##
==========================================
+ Coverage   95.41%   95.47%   +0.06%     
==========================================
  Files         174      174              
  Lines        2702     2697       -5     
==========================================
- Hits         2578     2575       -3     
+ Misses        124      122       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pixeldesu]

We talked about this in private already, I'll leave the feedback here just so we don't forget about it.

I'm not a fan of this approach because comparing against a pre-fetched set of IDs makes it harder to make independent components out of specific features. It brings a performance improvement, but at the cost of maintainability.

I'm personally not sure how to solve this. If a different way of caching, or using something like

if a global containing a pre-cached set of IDs is available, prefer that over fetching data yourself

could allow for both cases.

[raccube]

@pixeldesu @nilsding I rewrote this using subqueries, so the additional lookup queries aren't required at all.