This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Add .travis.yml configured to run eslint, and fix existing lint errors #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what exactly to do here to fix the Ruby check failures, looks like |
For now, I removed the Ruby checks so I can unblock this PR (since it contains JS changes that will conflict with my next PR). Opened this issue to revisit it in another PR: #2 |
mzazrivec
reviewed
Jul 12, 2019
mzazrivec
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic Travis CI configuration file which will run
yarn test
, and atest
script inpackage.json
which for now simply runs thelint
package script (which runs eslint). In the future we can add Jest tests to thetest
package script, and we can add things like CodeClimate to the Travis configuration.