Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Add .travis.yml configured to run eslint, and fix existing lint errors #1

Merged
merged 9 commits into from
Jul 15, 2019

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Jul 9, 2019

This PR adds a basic Travis CI configuration file which will run yarn test, and a test script in package.json which for now simply runs the lint package script (which runs eslint). In the future we can add Jest tests to the test package script, and we can add things like CodeClimate to the Travis configuration.

@mturley mturley requested a review from Fryguy July 9, 2019 20:39
@mturley
Copy link
Collaborator Author

mturley commented Jul 9, 2019

Not sure what exactly to do here to fix the Ruby check failures, looks like rake app:test:vmdb:setup is failing. It's probably related to the rspec stuff I ripped out temporarily.. @Fryguy do you think it's ok if I remove the Ruby checks from Travis for now and we revisit that when we're ready to look at Ruby tests here? Or would you rather I set up those tests in this PR?

@mturley
Copy link
Collaborator Author

mturley commented Jul 10, 2019

For now, I removed the Ruby checks so I can unblock this PR (since it contains JS changes that will conflict with my next PR). Opened this issue to revisit it in another PR: #2

@mturley mturley requested a review from mzazrivec July 10, 2019 16:39
@mzazrivec mzazrivec self-assigned this Jul 12, 2019
@mzazrivec mzazrivec added the enhancement New feature or request label Jul 12, 2019
Gemfile Show resolved Hide resolved
@mturley mturley requested a review from mzazrivec July 12, 2019 15:31
@mzazrivec mzazrivec merged commit 704baf7 into RedHatCloudForms:master Jul 15, 2019
@mturley mturley deleted the configure-travis branch July 15, 2019 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog/no enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants