Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseRTMPClientHandler.onChunkSize:Don't update writeChunkSize #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rawler
Copy link

@rawler rawler commented May 3, 2022

The RTMP specification states clearly, that "The maximum chunk size is
maintained independently for each direction". That means that our peer
updating its chunkSize, does not affect our outgoing chunkSize. A change
in writeChunkSize must be accompanied by a SetChunkSize message of our own,
otherwise our peer have no reliable way to know what chunksize to use for
each message.

https://rtmp.veriskope.com/docs/spec/?#541set-chunk-size-1

The RTMP specification states clearly, that "The maximum chunk size is
maintained independently for each direction". That means that our peer
updating its chunkSize, does not affect our outgoing chunkSize. A change
in writeChunkSize must be accompanied by a SetChunkSize message of our own,
otherwise our peer have no reliable way to know what chunksize to use for
each message.

https://rtmp.veriskope.com/docs/spec/?#541set-chunk-size-1
@rawler
Copy link
Author

rawler commented May 3, 2022

Some context; I've been struggling to get red5 working with another RTMP implementation. After digging around, it seems like the problem is that if SetChunkSize happens to be received by the client before sending the connect call, the connect call will be chunked using the chunk-size set by the peer, while the peer expects "our" (default) chunksize to be used.

@rawler
Copy link
Author

rawler commented May 11, 2022

@mondain Any chance to have a look at this?

@mondain
Copy link
Member

mondain commented May 11, 2022

@rawler thanks for the patch, I'll do a review / test and see about adding it as soon as I can. Also be aware that the on-going development of Red5 client is moved to the red5-server repo; the server project has been modularized instead of staying in separate repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants