Validation #2
Validation #2
Conversation
src/App.tsx
Outdated
| console.log("validateTextInput called with userInput:", userInput); | ||
|
|
||
| if (userInput && userInput.trim().length > 0) { | ||
| // Optionally, validate if the input is a valid URL | ||
| // For simplicity, we'll accept any non-empty text | ||
| return { success: true }; | ||
| } | ||
|
|
||
| return { | ||
| success: false, | ||
| promptContent: | ||
| "Please provide a valid URL or upload a file.", | ||
| promptDuration: 3000, | ||
| promptType: "error", | ||
| }; | ||
| }, |
There was a problem hiding this comment.
No need for validateTextInput here, since chatDisabled is already set to true.
src/App.tsx
Outdated
| const validationResult = validateFile(files[0]); | ||
| if (!validationResult.success) { | ||
| console.error(validationResult.promptContent); | ||
| // Return early to prevent success | ||
| return { success: false }; | ||
| } | ||
| console.log("File uploaded successfully:", files[0]); | ||
| } else { | ||
| console.error("No file provided."); | ||
| } |
There was a problem hiding this comment.
The validation for files were already performed in validateFileInput, so we don't have to repeat any checks here. Sufficient to just log the files received.
| "Thank you! Your input has been received. You passed the validation!", |
src/core/useRcbPlugin.ts
Outdated
| @@ -17,7 +18,7 @@ import { getValidator } from "../utils/getValidator"; | |||
| /** | |||
| * Plugin hook that handles all the core logic. | |||
| * | |||
| * @param pluginConfig configurations for the plugin | |||
| * @param pluginConfig Configurations for the plugin. | |||
There was a problem hiding this comment.
Unnecessary comment changes, there're some other ones in the rest of the code, can revert these changes :3
src/types/InputValidatorBlock.ts
Outdated
| validateInput: (userInput?: string) => ValidationResult; | ||
|
|
||
| export type InputValidatorBlock = Omit<Block, "file"> & { | ||
| file?: (params: { files?: FileList }) => void | Promise<void>; |
There was a problem hiding this comment.
The file attribute is already present in the original Block type, not needed here.
src/types/InputValidatorBlock.ts
Outdated
| export type InputValidatorBlock = Omit<Block, "file"> & { | ||
| file?: (params: { files?: FileList }) => void | Promise<void>; | ||
| validateTextInput?: (userInput?: string) => ValidationResult; | ||
| validateFileInput?: (file?: File) => ValidationResult; |
There was a problem hiding this comment.
It's actually possible that users may submit multiple files, so we have to cater to that possibility.
| } | ||
|
|
||
| if (!event.detail.currPath) { |
There was a problem hiding this comment.
Hmm any reason this was removed in favour of splitting into 2 separate checks?
src/core/useRcbPlugin.ts
Outdated
| console.error("No file uploaded."); | ||
| event.preventDefault(); | ||
| return; |
There was a problem hiding this comment.
Missing indentations, same for the code below.
Description
This PR introduces comprehensive file upload handling to the
input-validatorplugin, including validation for uploaded files and improved control over input types. It separates the validation logic for text and file inputs, adds real-time feedback for validation errors, and ensures backward compatibility with existing text-only behavior. Additionally, it provides a newchatDisabledproperty to control whether text input is allowed during specific flow blocks.Closes #1
What Change Does This PR Introduce?
Please select the relevant option(s):
Updated Implementation
File Upload Handling:
validateFileInputto handle file-specific validation, ensuring:filefunction to process file uploads asynchronously and validate uploaded files.Input Type Control:
chatDisabledproperty to control whether text input is allowed during a particular flow block.chatDisabled: true, only file uploads are permitted.Enhanced Validation Feedback:
Separation of Validation Logic:
validateTextInputapplies exclusively to text inputs.validateFileInputapplies exclusively to file uploads.Backward Compatibility:
Restored Original Styles:
Checklist
Testing
Verified the following scenarios:
chatDisabled: false.chatDisabled: true: Confirms that text input is disabled, allowing only file uploads.chatDisabledis not set.Additional Notes
This PR enhances the plugin significantly by adding robust support for file uploads, improved feedback mechanisms, and flexible input control. It maintains backward compatibility while aligning with the plugin's design philosophy.
Let me know if any further adjustments or additional documentation are required!