Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use multidict 6.0.5, add setuptools as dev dependency #172

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: Use multidict 6.0.5, add setuptools as dev dependency #172

merged 2 commits into from
Apr 9, 2024

Conversation

LisoUseInAIKyrios
Copy link
Contributor

Multidict 6.0.4 refused to install and gave an incompatibility error for me.
6.0.5 worked.

Also needed to add setuptools dependency or else Sanic would not start.

@oSumAtrIX oSumAtrIX requested a review from alexandreteles April 8, 2024 15:45
@alexandreteles alexandreteles changed the base branch from main to dev April 9, 2024 17:58
@alexandreteles
Copy link
Contributor

Multidict 6.0.4 refused to install and gave an incompatibility error for me. 6.0.5 worked.

Also needed to add setuptools dependency or else Sanic would not start.

Which Linux distribution/OS are you using?

@LisoUseInAIKyrios
Copy link
Contributor Author

MacOS

@alexandreteles
Copy link
Contributor

MacOS

Sadly, I am unable to test on MacOS so I will trust your report. Thank you!

@alexandreteles alexandreteles merged commit bf5eaa8 into ReVanced:dev Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreteles alexandreteles Awaiting requested review from alexandreteles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LisoUseInAIKyrios @alexandreteles