Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert new rules on list(NULL) assignment #6759

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

MichaelChirico
Copy link
Member

Reverts #6167 (retaining its tests). Closes #6740. Re-opens #5558.

cc @joshhwuu

Copy link

Comparison Plot

Generated via commit b9436f4

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 38 seconds
Installing different package versions 8 minutes and 16 seconds
Running and plotting the test cases 2 minutes and 22 seconds

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks.

@MichaelChirico
Copy link
Member Author

Failed tests are because I missed one line in R/data.table.R. I should have done the reversion more properly like so:

git revert 1aa92bc4ab3206b5e9f8accdc5b205edbb76c73a
# resolve conflicts
git commit -a

# restore changes to tests
git checkout 1aa92bc4ab3206b5e9f8accdc5b205edbb76c73a -- inst/tests/tests.Rraw
# resolve conflicts ?
git commit -a

I discovered the missing line by doing the above in a local branch and then checking git diff against this branch.

@MichaelChirico MichaelChirico merged commit bdbe15a into master Jan 30, 2025
7 of 9 checks passed
@MichaelChirico MichaelChirico deleted the revert-assign-null branch January 30, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revdep tidytable test failure after new NULL replacement
2 participants