Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the error more informative for #6556 #6713

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

venom1204
Copy link
Contributor

@venom1204 venom1204 commented Jan 8, 2025

In this i have made the error popping out to ber more informative by two things

Which column(s) are missing.
Which data.table is missing the column(s).
Closes #6556

@venom1204 venom1204 marked this pull request as draft January 8, 2025 14:32
@venom1204
Copy link
Contributor Author

Hi @aitap,
I hope you’re doing well! I’m currently facing some challenges with the atime performance test, and I could use your guidance.
Sorry for the disturbance, but if you have a moment, could you please help me figure out how to resolve this? I’d really appreciate your insights.
Thank you so much for your support!

@aitap
Copy link
Contributor

aitap commented Jan 8, 2025

It looks like the atime tests will only work with branches created inside the Rdatatable/data.table repository, not the outside forks. Unless you are a member of a team with write access to create new branches, there may be nothing you can fix.

Apologies for the poke, @Anirban166, could you help with this? If this is not by design (e.g. performance tests are relatively expensive and therefore must be run only from local branches), could the action create a local branch from refs/pull/<ID>/head instead of relying on ${GITHUB_HEAD_REF} (which seems to contain the branch name from the remote repository)?

@venom1204
Copy link
Contributor Author

Hi @MichaelChirico,
Apologies for the interruption, but could you kindly take a look at the issue with the atime performance tests? I’m running into an error, and it seems to be related to how the tests are triggered for pull requests from external forks.
If you could provide any guidance on how to resolve this, it would be greatly appreciated. Your help would mean a lot as I navigate this issue!

@MichaelChirico
Copy link
Member

You can ignore the atime issue

@venom1204 venom1204 marked this pull request as ready for review January 10, 2025 08:45
@venom1204
Copy link
Contributor Author

@MichaelChirico thanks for the clarification
can you please review the changes in the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] diagnostic for merge.data.table when by = key is not present in dt being merged
3 participants