Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #6350.
After the investigation, I am OK kicking the can on this one a bit further. I wanted to investigate since on first glance,
forder()
being length-0 looked more concerning. But in actuality, it just means "input is sorted", which is the same asbase::order()
finds, hence not show-stopping -- this is pretty deeply edge-case behavior anyway.I don't know enough about how
forder()
handles strings (especially w.r.t. encoding); AFAICT this will be a lot easier to debug after #6669 (since we can then use print-debugging to see how different parts of the routine give different results on different platforms).