Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix other.Rraw tests to run locally #6097

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix other.Rraw tests to run locally #6097

merged 1 commit into from
Apr 22, 2024

Conversation

MichaelChirico
Copy link
Member

Follow-up to #6090 -- since it seems this suite has not been run lately in CI, I tried locally and found it's not passing, fixed here.

Note that options(warn=1) in tests/other.R was doing nothing, since test.data.table() always sets warn=0:

data.table/R/test.data.table.R

Line 102 in d420afe

warn = 0L, # ensure signals are emitted as they are in the code, #5285

tdhock
tdhock approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your diligence Michael

@MichaelChirico MichaelChirico merged commit 20126b1 into master Apr 22, 2024
3 checks passed
@MichaelChirico MichaelChirico deleted the test-other branch April 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdhock tdhock tdhock approved these changes

@jangorecki jangorecki Awaiting requested review from jangorecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @tdhock