-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "na.print" as a new argument to "print.data.table" #6087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation looks good, including yes to including it in the |
Co-authored-by: Michael Chirico <[email protected]>
MichaelChirico
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3152
na.print
by exposing it as a new argument toprint.data.table
, instead of handling it through...
likeprint.data.frame
.print.data.table
or allowprint.default
to handle it.Currently,
na.print
allows for eitherNULL
or a character string to replaceNA
values when printing, butprint.data.table
does not handle this argument. I am suggesting we add thena.print
argument toprint.data.table
and pass it to existingprint.default
calls, although I think it is possible to handlena.print
through...
, although we will have to change some documentation and an extra check.As for error throwing and type checking, I think the
print.default
error is clear enough:However if we want to handle this error through
print.data.table
(maybe for clarity, translation, etc.), it should be easy enough to add. Currentlyquote
is handled byprint.default
so I think doing the same forna.print
would make sense.