Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify env setting for locale, add tz dimension in new occasional CI #6086

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplify env setting for locale, add tz dimension in new occasional CI #6086

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b329d47
simplify env setting for locale, add tz dimension
MichaelChirico Apr 12, 2024
66f3c97
Merge branch 'master' into ci-tz
MichaelChirico Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions .github/workflows/R-CMD-check-occasional.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,49 +15,33 @@ jobs:
matrix:
os: [macOS-latest, windows-latest, ubuntu-latest]
r: ['devel', 'release', '3.2', '3.3', '3.4', '3.5', '3.6', '4.0', '4.1', '4.2', '4.3']
locale: ['en_US.utf8', 'zh_CN.utf8', 'lv_LV.utf8'] # Chinese for translations, Latvian for collate order (#3502)
locale: ['en_US', 'zh_CN', 'lv_LV'] # Chinese for translations, Latvian for collate order (#3502)
tz: ['UTC', 'Asia/Seoul'] # Any non-UTC & widely available time zone
exclude: # only run non-English locale CI on Ubuntu
- os: macOS-latest
locale: 'zh_CN.utf8'
locale: 'zh_CN'
- os: macOS-latest
locale: 'lv_LV.utf8'
locale: 'lv_LV'
- os: windows-latest
locale: 'zh_CN.utf8'
locale: 'zh_CN'
- os: windows-latest
locale: 'lv_LV.utf8'
locale: 'lv_LV'

env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Set locale
if: matrix.locale == 'en_US.utf8'
- name: Generate locale
run: |
sudo locale-gen en_US
echo "LC_ALL=en_US.utf8" >> $GITHUB_ENV

- name: Set locale
if: matrix.locale == 'zh_CN.utf8'
run: |
sudo locale-gen zh_CN
echo "LC_ALL=zh_CN.utf8" >> $GITHUB_ENV
echo "LANGUAGE=zh_CN" >> $GITHUB_ENV

- name: Set locale
if: matrix.locale == 'lv_LV.utf8'
run: |
sudo locale-gen lv_LV
echo "LC_ALL=lv_LV.utf8" >> $GITHUB_ENV
echo "LANGUAGE=lv_LV" >> $GITHUB_ENV
sudo locale-gen ${{ matrix.locale }}

- uses: actions/checkout@v2

- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.r }}


- name: Query dependencies
run: |
install.packages('remotes')
Expand Down Expand Up @@ -89,6 +73,9 @@ jobs:
- name: Check
env:
_R_CHECK_CRAN_INCOMING_REMOTE_: false
TZ: ${{ matrix.tz }}
LC_ALL: ${{ matrix.locale }}.utf8
LANGUAGE: ${{ matrix.locale}}
run: |
options(crayon.enabled = TRUE)
rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check")
Expand Down
Loading