Use options= in test() for rarely-touched scripts #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data.table spacing style document in Rd Add options= to test() document in Rd missed staged chunk convert most Rraw scripts to use test(options=) Merge branch 'master' into test-options Merge remote-tracking branch 'origin/test-options' into test-options
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MichaelChirico and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6015 +/- ##
==========================================
+ Coverage 97.50% 97.52% +0.01%
==========================================
Files 80 80
Lines 14884 14884
==========================================
+ Hits 14513 14515 +2
+ Misses 371 369 -2 ☔ View full report in Codecov by Sentry. |
jangorecki
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #5845 to avoid conflicts. As noted (#5845 (comment)), these scripts are not touched in any active PRs and so don't have risk of causing gnarly conflicts in more important PRs.
The remaining scripts ({benchmark,froll,nafill,tests}.Rraw) can all be deferred to 1.17.0, or very late in 1.16.0.