Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove set2key,v, key2 #4081

Merged
merged 4 commits into from
Dec 17, 2019
Merged

remove set2key,v, key2 #4081

merged 4 commits into from
Dec 17, 2019

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Nov 28, 2019

As promised in news items we have passed May 2019 so we can now remove these.
Originally discussed in #3399.

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #4081 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4081      +/-   ##
=========================================
- Coverage    99.4%   99.4%   -0.01%     
=========================================
  Files          72      72              
  Lines       13696   13693       -3     
=========================================
- Hits        13615   13612       -3     
  Misses         81      81
Impacted Files Coverage Δ
R/setkey.R 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91e1b7...5e63fee. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.9 milestone Dec 17, 2019
@mattdowle mattdowle merged commit f84e33e into master Dec 17, 2019
@mattdowle mattdowle deleted the rm_set2key branch December 17, 2019 23:25
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants