-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep.rownames argument for transpose #3715
Conversation
add manual & NEWS
The confusing thing for me on this one is that
So the new In order words, given :
how to specify the following result should be returned by
|
Also, |
BTW @mattdowle this PR / issue is for |
Oh. We have our own |
|
Yes
Not sure what you mean here, but I'm not sure about the argument name Hm, I'm thinking there is no argument name that easily conveys what it does. How about changing |
Codecov Report
@@ Coverage Diff @@
## master #3715 +/- ##
==========================================
- Coverage 98.81% 98.78% -0.04%
==========================================
Files 70 70
Lines 13373 13393 +20
==========================================
+ Hits 13215 13230 +15
- Misses 158 163 +5
Continue to review full report at Codecov.
|
NEWS.md
Outdated
|
||
```R | ||
# default 4 threads on a laptop with 16GB RAM and 8 logical CPU | ||
x = sample(c(TRUE,FALSE), 3e8, replace=TRUE) # 1GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you went 5e8 to 3e8 for ifelse benchmark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make it 1GB. I don't remember changing it from 5e8 to 3e8 though; can't remember -- didn't I change something else at the same time too? Main change was getting away from 100 runs on small size. It can be 5e8 too.
…'rn') + added make.names= for the reverse. Tidied C code.
Follow-up PRs expected to be needed. |
Coverage issue seems to be related to |
|
Closes #1886
via #3189
I think the logic is basically done. Just want to do some more robustness checks & minor details, e.g.
As of now, the new column is named
V1
, should we name itrn
& bump the others to1-n
?2-(n+1)
?