Code

forderv handles complex input#3701

Code

Merged

mattdowle merged 33 commits intomasterRdatatable/data.table:masterfrom cplx_forderRdatatable/data.table:cplx_forderCopy head branch name to clipboardJul 19, 2019

+141-50

Commits

Commits on Jul 10, 2019

• Closes #1444 -- setkey works on tables with complex columns

  

  Michael Chirico

  committed
  73a63ca

  Copy full SHA for 73a63ca

• extra test for group operation mentioned in issue

  

  Michael Chirico

  committed
  bdce4a5

  Copy full SHA for bdce4a5

Commits on Jul 11, 2019

• new tests for coverage

  

  Michael Chirico

  committed
  e6533dc

  Copy full SHA for e6533dc

• missing arg

  

  Michael Chirico

  committed
  c210ede

  Copy full SHA for c210ede

Commits on Jul 12, 2019

• Closes #1703 -- forderv handles complex input

  

  Michael Chirico

  committed
  55bd501

  Copy full SHA for 55bd501

Commits on Jul 13, 2019

• slight re-tooling, now passing tests

  

  Michael Chirico

  committed
  2e8c996

  Copy full SHA for 2e8c996

• more progress; but stonewalled by bmerge

  

  Michael Chirico

  committed
  e3a6aa6

  Copy full SHA for e3a6aa6

• Merge branch 'master' of https://github.com/Rdatatable/data.table into cplx_forder

  

  Michael Chirico

  committed
  37e8431

  Copy full SHA for 37e8431

• moved new logic to C so e.g. bmerge can call it from there

  

  Michael Chirico

  committed
  52bcac0

  Copy full SHA for 52bcac0

• some coverage tests, extension to rleid()

  

  Michael Chirico

  committed
  bf59da2

  Copy full SHA for bf59da2

• progress making ctwiddle (dtwiddle for cplx)

  

  Michael Chirico

  committed
  09c8b19

  Copy full SHA for 09c8b19

• start preferring Rcomplex type

  

  Michael Chirico

  committed
  e5d1d1d

  Copy full SHA for e5d1d1d

• switch to Rcomplex API

  

  Michael Chirico

  committed
  9a4cef4

  Copy full SHA for 9a4cef4

• Merge branch 'master' of https://github.com/Rdatatable/data.table into cplx_setkey

  

  Michael Chirico

  committed
  494468f

  Copy full SHA for 494468f

Commits on Jul 14, 2019

• Merge branch 'cplx_setkey' into cplx_forder

  

  Michael Chirico

  committed
  e0b17b8

  Copy full SHA for e0b17b8

• setkey now works on complex columns

  

  Michael Chirico

  committed
  761fe90

  Copy full SHA for 761fe90

• ostensibly done uniqlist; progress on bmerge

  

  Michael Chirico

  committed
  7261011

  Copy full SHA for 7261011

Commits on Jul 17, 2019

• Merge branch 'master' into cplx_forder

  

  Michael Chirico

  committed
  25cdf0d

  Copy full SHA for 25cdf0d

• Merge branch 'master' into cplx_forder

  mattdowle

  authored
  681ab5d

  Copy full SHA for 681ab5d

Commits on Jul 18, 2019

• Merge branch 'master' into cplx_forder

  mattdowle

  authored
  81a941a

  Copy full SHA for 81a941a

• scale back attempts at bmerge, all of uniqlist

  

  Michael Chirico

  committed
  5f443cb

  Copy full SHA for 5f443cb

• tidy up tests

  

  Michael Chirico

  committed
  b922ee9

  Copy full SHA for b922ee9

• unique also works

  

  Michael Chirico

  committed
  b656541

  Copy full SHA for b656541

• updated NEWS item & added coverage tests

  

  Michael Chirico

  committed
  3c3228b

  Copy full SHA for 3c3228b

• one more nocov

  

  Michael Chirico

  committed
  009935c

  Copy full SHA for 009935c

• actually hit LGLSXP branch!

  

  Michael Chirico

  committed
  f59dc57

  Copy full SHA for f59dc57

• more coverage

  

  Michael Chirico

  committed
  0338226

  Copy full SHA for 0338226

• Merge branch 'master' into cplx_forder

  

  Michael Chirico

  committed
  523ab00

  Copy full SHA for 523ab00

Commits on Jul 19, 2019

• use direct double comparison instead of type punning

  

  Michael Chirico

  committed
  598097b

  Copy full SHA for 598097b

• replaced big block with smaller modification to the main loop; also halves the working ram needed as it reuses the same tmp for the rerun

  mattdowle

  committed
  2df22a3

  Copy full SHA for 2df22a3

• memcmp for complex instead of == on double

  mattdowle

  committed
  dd7b24a

  Copy full SHA for dd7b24a

• merge master

  mattdowle

  committed
  5e81694

  Copy full SHA for 5e81694

• news item tidy

  mattdowle

  committed
  a9d9165

  Copy full SHA for a9d9165