Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating setorder.Rd #3389

Merged
merged 4 commits into from
Feb 11, 2019
Merged

updating setorder.Rd #3389

merged 4 commits into from
Feb 11, 2019

Conversation

MichaelChirico
Copy link
Member

Related to #2572 (point 3)

I may have gone overboard with the radix sort references 🤷‍♂️

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #3389 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3389      +/-   ##
==========================================
- Coverage   95.09%   95.09%   -0.01%     
==========================================
  Files          65       65              
  Lines       12122    12120       -2     
==========================================
- Hits        11528    11526       -2     
  Misses        594      594
Impacted Files Coverage Δ
R/foverlaps.R 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd3a46...3311dca. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #3389 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3389   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files          65       65           
  Lines       12120    12120           
=======================================
  Hits        11526    11526           
  Misses        594      594

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267e314...ca5098f. Read the comment docs.

@mattdowle
Copy link
Member

mattdowle commented Feb 11, 2019

Nice edit. Much clearer. The youtube video was a bit too much about LSD integers. I replaced that with Terdiman and Herf links (repeated from ?setkey).
?setkey description looks a bit out-of-date too I noticed (I added a new point 4 to #2572 for that).

@mattdowle mattdowle added this to the 1.12.2 milestone Feb 11, 2019
@mattdowle mattdowle merged commit bebc32f into master Feb 11, 2019
@mattdowle mattdowle deleted the forder_dox branch February 11, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants