Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress towards #2572 (miscellaneous tests) #2605

Merged
merged 11 commits into from
Feb 22, 2018
Merged

Progress towards #2572 (miscellaneous tests) #2605

merged 11 commits into from
Feb 22, 2018

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Feb 3, 2018 •
edited
Loading

#2572 covers TODO tests/etc buried in inst/tests/tests.Rraw.

work in progress, but far enough along to start garnering comments if needed

@codecov-io
Copy link

codecov-io commented Feb 3, 2018 •
edited
Loading

Codecov Report

Merging #2605 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2605   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files          61       61           
  Lines       12120    12120           
=======================================
  Hits        11288    11288           
  Misses        832      832

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5174a8c...2d25df0. Read the comment docs.

@MichaelChirico MichaelChirico changed the title (WIP) Progress towards #2572 (WIP) Progress towards #2571 Feb 3, 2018
@mattdowle
Copy link
Member

mattdowle commented Feb 6, 2018 •
edited
Loading

What specifically is this PR for? Better specific title please as per point 4 in https://github.com/Rdatatable/data.table/wiki/Contributing. Issue #2571 is already closed and isn't about TODO in tests.Raw (and if so, which TODO in tests.Rraw?)

@MichaelChirico MichaelChirico changed the title (WIP) Progress towards #2571 (WIP) Progress towards #2572 (miscellaneous tests) Feb 7, 2018
@MichaelChirico
Copy link
Member Author

@mattdowle sorry, typo (i thought I fixed it), this is about #2572

Michael Chirico added 2 commits February 9, 2018 10:03
merge master into branch
1809962 
Merge branch 'master' of https://github.com/Rdatatable/data.table into add_todo_tests

# Conflicts:
#	inst/tests/tests.Rraw
new test via Pasha
2b7e78f
@mattdowle
Copy link
Member

Is this ready to be merged for the todo's done so far? Lots of small quick PRs is no problem and easier to manage than one big one.

@MichaelChirico MichaelChirico changed the title (WIP) Progress towards #2572 (miscellaneous tests) Progress towards #2572 (miscellaneous tests) Feb 18, 2018
@MichaelChirico
Copy link
Member Author

@mattdowle sure, go for it

@mattdowle mattdowle added this to the v1.10.6 milestone Feb 22, 2018
mattdowle
mattdowle approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@mattdowle mattdowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and much needed.
Thanks for taking this initiative!
Much better with the tracking and discussion in issue #2572.

@mattdowle mattdowle merged commit e2386ab into master Feb 22, 2018
@mattdowle mattdowle deleted the add_todo_tests branch February 22, 2018 21:16
@MichaelChirico MichaelChirico mentioned this pull request Dec 6, 2018
Open
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdowle mattdowle mattdowle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelChirico @codecov-io @mattdowle