Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdep tidytable test failure after new NULL replacement #6740

Closed
tdhock opened this issue Jan 20, 2025 · 0 comments · Fixed by #6759
Closed

revdep tidytable test failure after new NULL replacement #6740

tdhock opened this issue Jan 20, 2025 · 0 comments · Fixed by #6759
Labels
revdep Reverse dependencies
Milestone

Comments

@tdhock
Copy link
Member

tdhock commented Jan 20, 2025

revdep checker says that #6167 caused a new test failure in revdep tidytable:

* checking tests ...
  Running ‘testthat.R’
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  The following object is masked from 'package:base':
  
      %in%
  
  > 
  > test_check("tidytable")
  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 1335 ]
  
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-pivot_longer.R:229:3'): can drop the 'id' column by specifying NA ──
  Names of `out` ('.id', 'x', 'y') don't match 'x', 'y'
  
  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 1335 ]
  Error: Test failures

I verified on my local machine, and proposed a fix in tidytable, markfairbanks/tidytable#831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revdep Reverse dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant