Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated std::iterator #193

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Remove deprecated std::iterator #193

merged 1 commit into from
Jan 31, 2023

Conversation

Enchufa2
Copy link
Member

Moves away from std::iterator, and thus the warning in RMatrix.h. #121 is needed to remove warnings in bundled tbb.

Closes #192.

@egpivo egpivo mentioned this pull request Jan 29, 2023
Merged
kevinushey
kevinushey approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for putting this together!

Do we need to prepare a CRAN release of RcppParallel with this patch?

@kevinushey kevinushey merged commit 60406d2 into RcppCore:master Jan 31, 2023
@Enchufa2
Copy link
Member Author

I don't think this is a problem yet, and when it is, switching to a more recent version of tbb will be needed anyway. So I'd say no rush.

@Enchufa2 Enchufa2 deleted the fix/iterator branch January 31, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinushey kevinushey kevinushey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated std::iterator
2 participants
@Enchufa2 @kevinushey