Boulders block trainer sight #969
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
reviewed
Aug 9, 2024
Comment on lines
+283
to
+284
| cp SPRITE_BOULDER_ROCK_FOSSIL | ||
| jr nz, .next_left_check |
There was a problem hiding this comment.
I think if we do this at all, it should be a general-purpose "no trainer sight if there's any NPC in the way" check. (And even then, I'd prefer to redesign maps so the circumstance can't occur, if possible.)
vulcandth
added
the
patch-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wouldn't call this efficient... but it technically works. This will prevent trainer sight when a boulder is in the way. If we removed the boulder sprite check it will prevent trainer sight if anything is in the way.
My brain doesn't want to be efficient right now, so If you see ways to optimize please suggest and i'll apply. Furthermore, we may want to farcall some of this so it's not in the home bank? I'll leave that up to you.
Resolves #381