Sour Sprites Update #1017
Open
Sour Sprites Update #1017
+354
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
reviewed
Feb 3, 2025
Comment on lines
+1
to
+2
| RGB 31, 28, 0 | ||
| RGB 21, 10, 1 |
There was a problem hiding this comment.
Likewise for any other single-digit values.
Suggested change
| RGB 31, 28, 0 | |
| RGB 21, 10, 1 | |
| RGB 31, 28, 00 | |
| RGB 21, 10, 01 |
Rangi42
reviewed
Feb 3, 2025
Comment on lines
+1
to
+2
| RGB 18, 8, 19 | ||
| RGB 22, 4, 9 |
There was a problem hiding this comment.
This is a good example of single-digit values (and whitespace trimming) which didn't actually change the content, but are just formatted differently, which makes the PR look more drastic than it is.
Suggested change
| RGB 18, 8, 19 | |
| RGB 22, 4, 9 | |
| RGB 18, 8, 19 | |
| RGB 22, 4, 9 |
Rangi42
reviewed
Feb 3, 2025
gfx/pokemon/arbok/shiny.pal
Outdated
There was a problem hiding this comment.
And this is a color change, which I'm not sure is appropriate -- some of PC's shiny mons have intentionally different colors from the official ones (e.g. silver Scizor, blue Pikachu, etc).
Rangi42
requested changes
Feb 3, 2025
|
I think this is a duplicate of #990; where I cleaned up the superfluous changes... but if we wat to work off of this one.. that works too. |
vulcandth
added
enhancement
cosmetic
patch-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up-to-date sprites for Polished. Please convert each sprite both front and back to grayscale as needed