e2e: replace -run with -test.run for compatibility with e2e test executable #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
executable replace -run with -test.run, the -run flag is supported when using 'go test' directly, but compiled test executables (via 'go test -c') require the -test.run flag. Signed-off-by: Parikshith <[email protected]>
nirs
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the
-runoption with-test.runwhen executing compiled test binaries in e2e.doc.When using go test directly, the -run flag is supported ex:
go test -run Test. However, when tests are compiled into an executable usinggo test -c(ramen-e2e), the executable only recognizes flags prefixed with -test., such as -test.run.Using
-test.runensures compatibility in both scenarios, whether running tests via go test or executing a compiled test binary.ex:
go test -timeout 0 -v -test.run //appset-deploy-rbd