Return filename found on FS when getting from cache

RakambdaOrg · Nov 29, 2024 · 5eef9be · 5eef9be
1 parent 6b29767
commit 5eef9be
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -31,6 +31,7 @@
   "require": {
     "ext-dom": "*",
     "ext-curl": "*",
-    "ext-libxml": "*"
+    "ext-libxml": "*",
+    "ext-fileinfo": "*"
   }
 }
diff --git a/piccache.php b/piccache.php
@@ -500,15 +500,14 @@ public function store_in_cache(string $url): FetchHit
     public function get_cached_data(string $url): CacheHit
     {
         $this->store_in_cache($url);
-        if (!$this->is_cached($url)) {
+        $cached = $this->is_cached($url);
+        if (!$cached) {
             return new CacheHit();
         }
 
-        $file_name = $this->get_filename($url);
-        $file_size = filesize($file_name);
-
-        $content_type = mime_content_type($file_name);
-        return new CacheHit(true, $file_name, $file_size, $content_type);
+        $file_size = filesize($cached);
+        $content_type = mime_content_type($cached);
+        return new CacheHit(true, $cached, $file_size, $content_type);
     }
 
     private function is_cached(string $url): ?string