Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Send more data to MinuteWatched to make drops progress & Unrecognized field "count_by_md" #622

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Bug fix

Description

Seems like Twitch changed the data needed to be sent to the server in order to make drops progress.
See: rdavydov/Twitch-Channel-Points-Miner-v2#378

@Rakambda Rakambda added type: 🐛 bug Something isn't working app: ⛏️ miner labels Oct 21, 2023
@Rakambda Rakambda self-assigned this Oct 21, 2023
@Rakambda Rakambda requested a review from couchoud-t as a code owner October 21, 2023 16:12
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (084552e) 85.02% compared to head (d757752) 85.04%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #622      +/-   ##
=============================================
+ Coverage      85.02%   85.04%   +0.01%     
  Complexity      1060     1060              
=============================================
  Files            206      206              
  Lines           3366     3370       +4     
  Branches         251      251              
=============================================
+ Hits            2862     2866       +4     
  Misses           448      448              
  Partials          56       56              
Flag Coverage Δ
unittests-miner 85.43% <100.00%> (+0.01%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rakambda/channelpointsminer/miner/miner/Miner.java 96.96% <100.00%> (+0.02%) ⬆️
...pointsminer/miner/runnable/SendMinutesWatched.java 98.24% <100.00%> (+0.09%) ⬆️
...intsminer/miner/util/json/UnknownDeserializer.java 90.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rakambda Rakambda linked an issue Oct 21, 2023 that may be closed by this pull request
@Rakambda Rakambda linked an issue Oct 21, 2023 that may be closed by this pull request
@Rakambda Rakambda changed the title Fix: Send more data to MinuteWatched to make drops progress Fix: Send more data to MinuteWatched to make drops progress & Unrecognized field "count_by_md" Oct 21, 2023
@Rakambda Rakambda enabled auto-merge (squash) October 23, 2023 17:57
@Rakambda Rakambda disabled auto-merge October 23, 2023 17:57
@Rakambda Rakambda merged commit a2366d8 into develop Oct 23, 2023
@Rakambda Rakambda deleted the hotfix/gh-620 branch October 23, 2023 18:02
Rakambda added a commit that referenced this pull request Oct 23, 2023
* chore(deps): bump org.apache.logging.log4j:log4j-slf4j2-impl (#614)

Bumps org.apache.logging.log4j:log4j-slf4j2-impl from 2.20.0 to 2.21.0.

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-slf4j2-impl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump org.apache.logging.log4j:log4j-core (#615)

Bumps org.apache.logging.log4j:log4j-core from 2.20.0 to 2.21.0.

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas <[email protected]>

* 🔄 synced file(s) with RakambdaOrg/rakambda-github-files (#616)

Co-authored-by: undefined <[email protected]>

* chore(deps): bump com.codeborne:selenide from 6.19.0 to 6.19.1 (#617)

Bumps [com.codeborne:selenide](https://github.com/selenide/selenide) from 6.19.0 to 6.19.1.
- [Release notes](https://github.com/selenide/selenide/releases)
- [Changelog](https://github.com/selenide/selenide/blob/main/CHANGELOG.md)
- [Commits](selenide/selenide@v6.19.0...v6.19.1)

---
updated-dependencies:
- dependency-name: com.codeborne:selenide
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump org.xerial:sqlite-jdbc from 3.43.2.0 to 3.43.2.1 (#618)

Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.43.2.0 to 3.43.2.1.
- [Release notes](https://github.com/xerial/sqlite-jdbc/releases)
- [Changelog](https://github.com/xerial/sqlite-jdbc/blob/master/CHANGELOG)
- [Commits](xerial/sqlite-jdbc@3.43.2.0...3.43.2.1)

---
updated-dependencies:
- dependency-name: org.xerial:sqlite-jdbc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump org.springframework.boot from 3.1.4 to 3.1.5 (#619)

Bumps [org.springframework.boot](https://github.com/spring-projects/spring-boot) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: org.springframework.boot
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix: Send more data to MinuteWatched to make drops progress & Unrecognized field "count_by_md" (#622)

* Fix: send more data to minute watched event

See: rdavydov/Twitch-Channel-Points-Miner-v2#378

* tests

* Refactor

* Fix for #623

* Bump version

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized field "count_by_md" 2.2.9 Not progressing drops
1 participant