Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create csv reporter #38

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

araujogui
Copy link
Contributor

No description provided.

@@ -0,0 +1,36 @@
const { format } = require("@fast-csv/format");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a library for that since we are just piping it to stdout. If we use regular streams it should be fast enough for users.

Copy link
Owner

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have some tests?

@araujogui
Copy link
Contributor Author

Could we have some tests?

I created tests for the csvReport, but it's isolated from the test suite, unlike the other reporter tests. I’d like to know what you think about it.

Copy link
Owner

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added the enhancement New feature or request label Jan 8, 2025
@RafaelGSS
Copy link
Owner

Could we have some tests?

I created tests for the csvReport, but it's isolated from the test suite, unlike the other reporter tests. I’d like to know what you think about it.

That's fine, I can improve it if needed in the future :).

@RafaelGSS RafaelGSS merged commit 11be8e5 into RafaelGSS:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants