Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KilledbyMicrosoftBridge] New Bridge #3960

Closed
wants to merge 3 commits into from
Closed

[KilledbyMicrosoftBridge] New Bridge #3960

wants to merge 3 commits into from

Conversation

tillcash
Copy link
Contributor

@tillcash tillcash commented Feb 7, 2024

No description provided.

Copy link

github-actions bot commented Feb 7, 2024

Pull request artifacts

Bridge Context Status
KilledbyMicrosoft 1 untitled (pr) ✔️

last change: Wednesday 2024-02-07 17:28:49

@tillcash tillcash closed this Feb 7, 2024
$json = getContents('https://killedbymicrosoft.info/graveyard.json');

// Decode JSON data
$discontinuedServices = json_decode($json, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Json::decode

// Process each item
foreach ($discontinuedServices as $service) {
// Concatenate service name with dateOpen and dateClose
$title = "{$service['name']} ({$service['dateOpen']} - {$service['dateClose']})";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please dont interpolate variables like this with curly braces. i think it's deprecated in 8.3 or something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will summit newly.

@dvikan
Copy link
Contributor

dvikan commented Feb 7, 2024

why close pr? i think it's a cool bridge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants