Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support itunes namespace in top channel feed #3776

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

dvikan
Copy link
Contributor

@dvikan dvikan commented Oct 19, 2023

This is a draft.

This change basically allows bridges to almost arbitrarily tweak the <channel> element for Mrss (and Atom )format.

Example:

class TestBridge extends BridgeAbstract
{
    public function getFeed(): array
    {
        return [
            'language' => 'en-US',
            'generator' => 'rss-bridge 2023',
            'itunes' => [
                'image' => 'https://example.com/foo.png',
                'explicit' => 'false',
            ],
        ];
    }
}

Still needs a bit work. Would love some feedback.

[0] https://podcasters.apple.com/support/823-podcast-requirements

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Pull request artifacts

Bridge Context Status
Itaku 1 Image Search (current) ⚠️ WARNING Uninitialized string offset 0 at bridges/ItakuBridge.php line 206
Itaku 1 Image Search (pr) ⚠️ WARNING Uninitialized string offset 0 at bridges/ItakuBridge.php line 206
Itaku 2 Post Search (current) ⚠️ WARNING Uninitialized string offset 0 at bridges/ItakuBridge.php line 244
⚠️ (shutdown) 8192: explode(): Passing null to parameter #2 ($string) of type string is deprecated in bridges/ItakuBridge.php line 242
Itaku 2 Post Search (pr) ⚠️ WARNING Uninitialized string offset 0 at bridges/ItakuBridge.php line 244
⚠️ (shutdown) 8192: explode(): Passing null to parameter #2 ($string) of type string is deprecated in bridges/ItakuBridge.php line 242
Itaku 3 User profile (current) Missing example or default value for parameter "user"
Itaku 3 User profile (pr) Missing example or default value for parameter "user"
Itaku 4 Home feed (current) ✔️
Itaku 4 Home feed (pr) ✔️

last change: Tuesday 2024-01-09 19:15:29

@dvikan
Copy link
Contributor Author

dvikan commented Jan 9, 2024

okay this isnt completely finished.
but it's an improvement in trying to preserve the original feed structure.
merging.

@dvikan dvikan merged commit 3ce9440 into RSS-Bridge:master Jan 9, 2024
7 checks passed
@dvikan dvikan deleted the feat-itunes-2 branch January 9, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant