Fix: content.php: last-modified/if-unmodified-since (#3771) (#3772)

* Fix: content.php: last-modified/if-unmodified-since (#3771)

Fix exception if server sent invalid Last-Modified header
Add support for Unix time instead of standard date string
Send back standard RFC7231 date string instead of Unix time

* Fix: content.php: if-unmodified-since: cURL API

Use getTimestamp() as cURL expects that and will format the If-Modified-Since header appropriately.

lib/contents.php

@@ -63,8 +63,13 @@ function getContents(
     if ($cachedResponse) {
         $cachedLastModified = $cachedResponse->getHeader('last-modified');
         if ($cachedLastModified) {
-            $cachedLastModified = new \DateTimeImmutable($cachedLastModified);
-            $config['if_not_modified_since'] = $cachedLastModified->getTimestamp();
+            try {
+                // Some servers send Unix timestamp instead of RFC7231 date. Prepend it with @ to allow parsing as DateTime
+                $cachedLastModified = new \DateTimeImmutable((is_numeric($cachedLastModified) ? '@' : '') . $cachedLastModified);
+                $config['if_not_modified_since'] = $cachedLastModified->getTimestamp();
+            } catch (Exception $dateTimeParseFailue) {
+                // Ignore invalid 'Last-Modified' HTTP header value
+            }
         }
     }