Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warnings #1601

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix warnings #1601

wants to merge 1 commit into from
+5 −5

Conversation

TorreZuk
Copy link
Contributor

  • fix warnings with updated amdclang

@TorreZuk
Copy link
Contributor Author

warning: a declarative nested name specifier cannot name an alias template [-Walias-template-in-declaration-name]

@ellosel ellosel self-requested a review January 29, 2025 15:38
ellosel
ellosel approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ellosel ellosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TorreZuk I have these changes in another PR but we can merge this instead.

@TorreZuk
Copy link
Contributor Author

LOL I had a suspicion but looked through the PRs and didn't spot it. Got sick of seeing these warnings. Unfortunately this hit the test timeout which must have nothing to do with this PR. Mentioned in separate thread the tests need to be refactored ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellosel ellosel ellosel approved these changes

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TorreZuk @ellosel