Make global soln indices deterministic #1599
Conversation
b-shi
requested review from
jichangjichang,
KKyang,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
|
What happens when a solution is removed in the middle? |
Do you mean when we delete duplicate solutions? In that case it should fine, since, afaik, that step is done in serial. The non-determinism comes from creating the master library in parallel. |
No, I mean if a solution is replaced by a faster solution, or it is removed due to new optimizations that makes another existing kernel faster. You noticed that indices change between builds and you want to make them deterministic. |
| for localIdx, _, s in libraryIter(masterLibrary): | ||
| matchTable[s.index] = [s.srcName, localIdx] | ||
| LibraryIO.write("MatchTable", matchTable) | ||
|
|
There was a problem hiding this comment.
Should the MatchTable be written out after solution sorting?
There was a problem hiding this comment.
Ah, good catch, thanks!
Oh, I meant for the same commit (no changes to library logic files) if we rebuild multiple times the global solution indices may be different. We can see this by checking the contents of |
Currently, global solution indices can change between different builds. This PR sorts the global solution indices to make them deterministic.