Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swizzle support for hipBLASLt #1584

Merged
merged 23 commits into from
Feb 6, 2025
Merged

Conversation

Serge45
Copy link
Collaborator

@Serge45 Serge45 commented Jan 23, 2025

No description provided.

@Serge45 Serge45 force-pushed the feature/swizzle-api branch from e56a9ea to f764c3e Compare January 23, 2025 06:55
@Serge45 Serge45 changed the title [Draft] Swizzle support for hipBLASLt Swizzle support for hipBLASLt Jan 23, 2025
@Serge45 Serge45 marked this pull request as ready for review January 23, 2025 08:09
@jichangjichang
Copy link
Collaborator

Please add documentation for hipblasLtOrder_t .

Copy link
Collaborator

@jichangjichang jichangjichang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The freesize solution we put should support activation

@Serge45 Serge45 force-pushed the feature/swizzle-api branch from f764c3e to f581699 Compare January 23, 2025 08:26
amd-jnovotny
amd-jnovotny previously approved these changes Jan 23, 2025
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggested rewording to the docs for style guide consistency and clarity. Do we need a changelog entry for this?

docs/api-reference.rst Outdated Show resolved Hide resolved
@jichangjichang
Copy link
Collaborator

Just one suggested rewording to the docs for style guide consistency and clarity. Do we need a changelog entry for this?

I will add this into changelog before next ROCm release.

Co-authored-by: Jeffrey Novotny <[email protected]>
@Serge45 Serge45 merged commit 294161c into ROCm:develop Feb 6, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants