feat(HMS-2255): deploy to image RG by default #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use image RG by default and display clearly what the default is. This also removes the region selection entirely, as we default to the Resource Group location(region) and that's the best practice in Azure, so we don't want to promote overriding it.
akhil-jha
approved these changes
Oct 26, 2023
|
@amirfefer can you take a look pls? :) |
|
I like the solution we landed on, it is simple enough. Thanks. |
|
Amir won't get to it anytime soon, I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use image RG by default and display clearly what the default is.
This also removes the region selection entirely, as we default to the Resource Group location(region) and that's the best practice in Azure, so we don't want to promote overriding it.
We have went to allowing Customers to shoot themselves in the foot a bit by selecting a wrong resource group, but we decided that's a better option, than disabling it completely, as we found customer value in customizing the RG.
Second version to #353 with enabling override for the resource group.
Screencast.from.2023-10-25.13-17-04.webm